This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 3/5] New port: CR16: gdb port
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Kaushik Phatak <Kaushik dot Phatak at kpitcummins dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 22 Nov 2012 09:50:10 -0800
- Subject: Re: [RFA 3/5] New port: CR16: gdb port
- References: <C6CA53A2A46BA7469348BDBD663AB65845B2FF80@KCHJEXMB03.kpit.com> <507279C7.8080401@codesourcery.com> <C6CA53A2A46BA7469348BDBD663AB65845B39A2F@KCHJEXMB02.kpit.com> <20121022224107.GB3713@adacore.com> <C6CA53A2A46BA7469348BDBD663AB65845B3E44A@KCHJEXMB02.kpit.com> <20121023135502.GA3555@adacore.com> <C6CA53A2A46BA7469348BDBD663AB65845B3EB9E@KCHJEXMB02.kpit.com> <20121115174313.GC3790@adacore.com> <C6CA53A2A46BA7469348BDBD663AB65845B614E5@KCHJEXMB02.kpit.com>
> > + allWords =
> > Can you please void using the mixed-cap style for variables?
> This variable along with currInsn suffer from the same problem. However, they
> have been borrowed from existing code from opcodes/cr16-dis.c
> May I leave them here as is for now as it is used at several places in cr16-dis.c?
Yes. I thought it was a variable declared inside GDB. This is fine.
> 2012-11-20 Kaushik Phatak <kaushik.phatak@kpitcummins.com>
>
> gdb/Changelog
> * configure.tgt: Handle cr16*-*-*linux and cr16*-*-*.
> * cr16-linux-tdep.c: New file.
> * cr16-tdep.c: New file.
> * cr16-tdep.h: New file.
A couple of very very minor nits. Pre-approved with the changes
requested below. Once you get approval for the BFD bits, you may
commit this patch. When you do, can you send us a notification,
as well as a copy of the patch that you commit (because it is
going to be different from the one posted here).
> + if (p->has_frame_ptr)
> + {
> + CORE_ADDR fp = get_frame_register_unsigned (this_frame, CR16_FP_REGNUM);
> + return fp - p->frame_ptr_offset;
> + }
> + else
> + {
> + CORE_ADDR sp = get_frame_register_unsigned (this_frame, CR16_SP_REGNUM);
> + return sp - p->frame_size;
> + }
Missing empty line after variable declaration in both blocks.
> +};
Can you remov the trailing spaces?
Thank you,
--
Joel