This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v6 3/3] MI: tests for -catch-load/-catch-unload

From: Tom Tromey <tromey at redhat dot com>
To: Mircea Gherzan <mircea dot gherzan at intel dot com>
Cc: gdb-patches at sourceware dot org, keven dot boell at intel dot com, marc dot khouzam at ericsson dot com, vladimir at codesourcery dot com
Date: Tue, 27 Nov 2012 12:09:03 -0700
Subject: Re: [PATCH v6 3/3] MI: tests for -catch-load/-catch-unload
References: <1354031591-20226-1-git-send-email-mircea.gherzan@intel.com> <1354031591-20226-3-git-send-email-mircea.gherzan@intel.com>

>>>>> "Mircea" == Mircea Gherzan <mircea.gherzan@intel.com> writes:

Mircea> +mi_gdb_test "333-exec-continue" ".*" "catch-unload: run"
Mircea> +
Mircea> +gdb_expect {
Mircea> +    -re ".*stopped.*reason=\"solib-event\".*removed=.*\r\n.*\r\n$mi_gdb_prompt$" {
Mircea> +        pass "catch-unload: solib-event stop"
Mircea> +    }
Mircea> +    -re ".*\r\n$mi_gdb_prompt$" {
Mircea> +        fail "catch-unload: solib-event stop"
Mircea> +    }
Mircea> +    timeout {
Mircea> +        fail "(timeout) catch-unload: solib-event stop"
Mircea> +    }
Mircea> +}

I am not sure but this kind of thing seems racy to me.
Can't that ".*" in the mi_gdb_test suck up an arbitrary amount of gdb
output, perhaps enough to cause gdb_expect not to see the data it needs
to match?
I think some other approach is needed.

Tom

References:
- [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
  - From: Mircea Gherzan
- [PATCH v6 3/3] MI: tests for -catch-load/-catch-unload
  - From: Mircea Gherzan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]