This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands

From: Mircea Gherzan <mircea dot gherzan at intel dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: gdb-patches at sourceware dot org, keven dot boell at intel dot com, marc dot khouzam at ericsson dot com, vladimir at codesourcery dot com
Date: Thu, 29 Nov 2012 17:22:19 +0100
Subject: Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
References: <1354031591-20226-1-git-send-email-mircea.gherzan@intel.com> <87obiidfxl.fsf@fleche.redhat.com>

Thanks for your review.

On 27.11.2012 20:05, Tom Tromey wrote:

I wouldn't mind hearing Pedro's thoughts on this change, particularly
the breakpoint part.

Mircea> +  DEF_MI_CMD_MI ("catch-load", mi_cmd_catch_load),
Mircea> +  DEF_MI_CMD_MI ("catch-unload", mi_cmd_catch_unload),

I notice that these don't suppress the async breakpoint notification.

It seems more consistent to me to suppress the notification and then
print the new breakpoint information as the result of this command.

This has been fixed in v7 of the series.

Mircea

--

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Peter Gleissner, Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

Follow-Ups:
- Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
  - From: Tom Tromey

References:
- [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
  - From: Mircea Gherzan
- Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]