This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
Am 29.11.2012 22:08, schrieb Tom Tromey:
>>>>>> "Mircea" == Mircea Gherzan <mircea.gherzan@intel.com> writes:
>
>>> It seems more consistent to me to suppress the notification and then
>>> print the new breakpoint information as the result of this command.
>
> Mircea> This has been fixed in v7 of the series.
>
> There were some other review comments you haven't addressed yet: more
> comments for the one function in breakpoint.c, and possible raciness in
> the test case.
The possible raciness has also been addressed in v7, since no more async
notifications are present: we just use the ^done reply to carry the
catchpoint info. Furthermore, "mi_send_resuming_command" is used now.
I just wanted to collect some feedback regarding the suppression of the
async notifications before sending v8 (hopefully the last iteration).
--
Mircea