This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Skip multi-arch.exp if i*86-linux.


On 12/05/2012 07:39 PM, Doug Evans wrote:
> Hi.
> 
> I will commit this in a few days if there are no objections.
> If there are objections, please commit the fix you prefer.

A 32-bit gdb debugging against a 64-bit gdbserver should pass this
test, provided it was built with --enable-64-bit-bfd, but
a 32-bit gdb can't debug a 64-bit program, even if configured with
--enable-64-bit-bfd, so it seems like it might not be so simple to
come up with some sort of check that doesn't hardcode something.
So, no objections from me.

Thanks,
-- 
Pedro Alves

> 
> (gdb) file /home/dje/gnu/sourceware/pure-gdb/build/obj32/gdb/testsuite/gdb.multi/ma-hello
> "/home/dje/gnu/sourceware/pure-gdb/build/obj32/gdb/testsuite/gdb.multi/ma-hello": not in executable format: File format not recognized
> ERROR: Couldn't load /home/dje/gnu/sourceware/pure-gdb/build/obj32/gdb/testsuite/gdb.multi/ma-hello into /home/dje/gnu/sourceware/pure-gdb/build/obj32/gdb/testsuite/../../gdb/gdb.
> 
> 2012-12-05  Doug Evans  <dje@google.com>
> 
> 	* gdb.multi/multi-arch-exec.exp: Skip for i*86-linux.
> 	* gdb.multi/multi-arch.exp: Ditto.
> 
> Index: gdb.multi/multi-arch-exec.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.multi/multi-arch-exec.exp,v
> retrieving revision 1.1
> diff -u -p -r1.1 multi-arch-exec.exp
> --- gdb.multi/multi-arch-exec.exp	9 Nov 2012 12:20:24 -0000	1.1
> +++ gdb.multi/multi-arch-exec.exp	5 Dec 2012 19:32:29 -0000
> @@ -23,6 +23,12 @@ if [target_info exists use_gdb_stub] {
>      return
>  }
>  
> +# The 64-bit compile may succeed for i386-linux, but gdb won't be able
> +# to load the file.
> +if [istarget "i?86-*linux*"] {
> +    return
> +}
> +
>  # Can't use standard_testfile, we want executables with specialized
>  # names.
>  set exec1 "multi-arch-exec"
> Index: gdb.multi/multi-arch.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.multi/multi-arch.exp,v
> retrieving revision 1.1
> diff -u -p -r1.1 multi-arch.exp
> --- gdb.multi/multi-arch.exp	9 Nov 2012 01:47:20 -0000	1.1
> +++ gdb.multi/multi-arch.exp	5 Dec 2012 19:32:29 -0000
> @@ -23,6 +23,12 @@ if [target_info exists use_gdb_stub] {
>      return
>  }
>  
> +# The 64-bit compile may succeed for i386-linux, but gdb won't be able
> +# to load the file.
> +if [istarget "i?86-*linux*"] {
> +    return
> +}
> +
>  # Can't use standard_testfile, we want executables with specialized
>  # names.
>  set exec1 "ma-hello"
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]