This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] Add a test case for the jit-reader interface.


> I do not understand "Do.".  Either "Likewise." or also "New file.".

Fixed.

> For GDB repository it is only 2012.

Fixed.

> It executes:
>         run {set debug jit 1}
> Use:
>         gdb_test_no_output "set debug jit 1"

Fixed.

> It executes: (gdb) run run
>
> Besides that it does not wait on the SIGTRAP output it produces, so it is
> racy.  use:
>         gdb_run_cmd
>         gdb_test "" "Program received signal SIGTRAP, .*" "expect SIGTRAP"

Fixed.

> I do not understand why you do not use gdb/jit.h here?  This file is
> a duplicate.  Sorry if it was already discussed during initial JIT review.

I don't think this has been discussed, but my justification is that
we'd want the JIT tests to break if we make ABI incompatible changes
to the structures in jit.h (which, loosely speaking, are part of GDB's
"interface").


As an aside, something seems to have gone wrong with my SSH keys and I
was wondering if someone could commit my work (patches attached) for
me, if that is permissible.

--
Sanjoy Das
http://playingwithpointers.com

Attachment: 0001-Fix-segfault-when-unwinding-JIT-frames-using-a-custo.patch
Description: Binary data

Attachment: 0002-Make-jit-reader-load-accept-absolute-paths-to-reader.patch
Description: Binary data

Attachment: 0003-Add-a-test-case-for-the-jit-reader-interface.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]