This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch v5 07/12] btrace, doc: document remote serial protocol


> From: markus.t.metzger@intel.com
> Cc: markus.t.metzger@gmail.com, jan.kratochvil@redhat.com, palves@redhat.com,        tromey@redhat.com, kettenis@gnu.org,        Markus Metzger <markus.t.metzger@intel.com>
> Date: Fri,  7 Dec 2012 11:37:19 +0100
> 
> From: Markus Metzger <markus.t.metzger@intel.com>
> 
> Document the extensions to the remote serial protocol for supporting branch tracing.
> 
> 2012-12-07 Markus Metzger <markus.t.metzger@intel.com>
> 
> doc/
> 	* gdb.texinfo (Requirements): List qXfer:btrace:read requiring expat.
> 	(General Query Packets): Describe qbtrace, Qbtrace, and qXfer:btrace:read.

Thanks.

> +Return a description of the current branch trace.
> +@xref{Branch Trace Format}.  The annex part of the generic @samp{qXfer}
> +packet contains the thread id (see @ref{thread-id syntax}) for which
                                  ^^^^^^^^
Please use @pxref instead of "see @ref".

> +In order to display the branch trace of an inferior thread,
> +@value{GDBN} needs to obtain the list of branches. This list is

Two spaces between sentences, please (here and elsewhere in the
patch).

OK with those changes.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]