This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [doc patch] coding style: 0 vs. NULL + [patch] Code cleanup: skip.c

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: gdb-patches at sourceware dot org, Matt Rice <ratmice at gmail dot com>, Pedro Alves <palves at redhat dot com>
Date: Tue, 11 Dec 2012 07:51:27 +0100
Subject: Re: [doc patch] coding style: 0 vs. NULL + [patch] Code cleanup: skip.c
References: <20121210184220.GA29321@host2.jankratochvil.net> <20121211015343.GM31477@adacore.com> <20121211060641.GA7775@host2.jankratochvil.net>

On Tue, 11 Dec 2012 07:06:41 +0100, Jan Kratochvil wrote:
> OK         if (first)
> not great  if (!first)
> OK         if (first == NULL)
> OK         if (first != NULL)
> BAD        if (first == 0)
> BAD        if (first != 0)

BTW c++ -Wzero-as-null-pointer-constant warns only about the last two cases.


Jan

References:
- [doc patch] coding style: 0 vs. NULL + [patch] Code cleanup: skip.c
  - From: Jan Kratochvil
- Re: [doc patch] coding style: 0 vs. NULL + [patch] Code cleanup: skip.c
  - From: Joel Brobecker
- Re: [doc patch] coding style: 0 vs. NULL + [patch] Code cleanup: skip.c
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]