This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: remove deprecated_sym_private


> Here's another deprecation removal, this time deprecated_sym_private.
> Like the previous patch, this changes all the users to use objfile_data
> instead.

Thanks again!

> 	* coffread.c (coff_objfile_data_key): New global.
> 	(coff_symfile_init): Use set_objfile_data.
> 	(coff_symfile_read): Use objfile_data.
> 	(coff_symfile_finish): Don't free deprecated_sym_private.
> 	(coff_free_info): New function.
> 	(_initialize_coffread): Initialize coff_objfile_data_key.
> 	* mdebugread.c (pending_list): Update comment.
> 	* objfiles.h (struct objfile) <deprecated_sym_private>: Remove.
> 	* symfile.c (reread_symbols): Don't mention
> 	deprecated_sym_private.
> 	* xcoffread.c (xcoff_objfile_data_key): New global.
> 	(XCOFF_DATA): New macro.
> 	(process_linenos, enter_line_range, xcoff_next_symbol_text)
> 	(read_xcoff_symtab, coff_getfilename, read_symbol_lineno): Use
> 	XCOFF_DATA.
> 	(xcoff_new_init) Use set_objfile_data.
> 	(xcoff_symfile_finish): Don't free deprecated_sym_private.
> 	(init_stringtab, swap_sym, scan_xcoff_symtab)
> 	(xcoff_get_toc_offset, xcoff_initial_scan): Use XCOFF_DATA.
> 	(xcoff_free_info): New function.
> 	(_initialize_xcoffread): Initialize xcoff_objfile_data_key.

Also tested succesfully on ppc-aix and x86-windows (both with
GNU ld and DWARF - no stabs support).

I forgot to say it for the other patch, but I no longer have access
to pa-hpux, so no testing for SOM. That being said, looking at the
actual changes, I am not worried.

> +/* The pending information is kept for an entire object file We

Missing period before "We"? (at the end of the line)

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]