This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFC] Remove GNU/Linux ARI rule
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Date: Sun, 23 Dec 2012 19:28:46 +0100
- Subject: [RFC] Remove GNU/Linux ARI rule
A long time ago,
I submitted a patch trying to reduce the number of ARI
warnings about GNU/Linux rule:
http://sourceware.org/ml/gdb/2009-04/msg00103.html
Somewhere along the following suggestion,
someone proposed to simply remove this rule.
So I would like to start a discussion about
the removal of ARI rule concerning GNU/Linux in comments.
Pierre Muller
as ARI maintainer
2012-12-23 Pierre Muller <muller@sourceware.org>
* contrib/ari/gdb_ari.sh (GNU/Linux rule): Comment out.
Index: contrib/ari/gdb_ari.sh
===================================================================
RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v
retrieving revision 1.6
diff -u -r1.6 gdb_ari.sh
--- contrib/ari/gdb_ari.sh 29 Nov 2012 17:23:18 -0000 1.6
+++ contrib/ari/gdb_ari.sh 23 Dec 2012 18:27:01 -0000
@@ -257,20 +257,23 @@
# Things in comments
-BEGIN { doc["GNU/Linux"] = "\
-Do not use `Linux'\'', instead use `Linux kernel'\'' or `GNU/Linux
system'\'';\
- comments should clearly differentiate between the two (this test assumes
that\
- word `Linux'\'' appears on the same line as the word `GNU'\'' or
`kernel'\''\
- or a kernel version"
- category["GNU/Linux"] = ari_comment
-}
-/(^|[^_[:alnum:]])Linux([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux\[sic\]([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])GNU\/Linux([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux [[:digit:]]\.[[:digit:]]+)/ {
- fail("GNU/Linux")
-}
+# This rule has been disabled
+# because it produces more false alarms thaan useful
+# warnings.
+# BEGIN { doc["GNU/Linux"] = "\
+# Do not use `Linux'\'', instead use `Linux kernel'\'' or `GNU/Linux
system'\'';\
+# comments should clearly differentiate between the two (this test assumes
that\
+# word `Linux'\'' appears on the same line as the word `GNU'\'' or
`kernel'\''\
+# or a kernel version"
+# category["GNU/Linux"] = ari_comment
+# }
+# /(^|[^_[:alnum:]])Linux([^_[:alnum:]]|$)/ \
+# && !/(^|[^_[:alnum:]])Linux\[sic\]([^_[:alnum:]]|$)/ \
+# && !/(^|[^_[:alnum:]])GNU\/Linux([^_[:alnum:]]|$)/ \
+# && !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
+# && !/(^|[^_[:alnum:]])Linux [[:digit:]]\.[[:digit:]]+)/ {
+# fail("GNU/Linux")
+# }
BEGIN { doc["ARGSUSED"] = "\
Do not use ARGSUSED, unnecessary"