This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] MI notification on trace started/stopped:basic
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 07 Jan 2013 19:19:30 +0000
- Subject: Re: [PATCH 1/3] MI notification on trace started/stopped:basic
- References: <1355914499-5268-1-git-send-email-yao@codesourcery.com> <1355914499-5268-2-git-send-email-yao@codesourcery.com>
Looks good to me.
edit: I actually have a comment in patch 3/3.
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 8c59065..9b905b6 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
...
> +@item =trace-started[,notes="@var{notes}"]
> +@itemx =trace-stopped[,notes="@var{notes}"]
> +Reports that trace was started or stopped. The optional
> +@code{notes="@var{notes}"} part is reported if trace notes or
> +stop trace notes are not NULL.
> @end table
This being gdb.texinfo, the user manual, not the internals
manual, I don't think "NULL" is the right term here.
--
Pedro Alves