This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] async remote notification 'Trace'.
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 07 Jan 2013 19:20:27 +0000
- Subject: Re: [PATCH 2/3] async remote notification 'Trace'.
- References: <1355914499-5268-1-git-send-email-yao@codesourcery.com> <1355914499-5268-3-git-send-email-yao@codesourcery.com>
Codewise it looks good to me, but I'd like to see docs
for the RSP bits before it goes in.
On 12/19/2012 10:54 AM, Yao Qi wrote:
> +static void
> +remote_notif_trace_parse (struct notif_client *self, char *buf,
> + struct notif_event *event)
> +{
> + if (strncmp (buf, "stop:", 5) == 0)
> + parse_trace_status (buf + 5 + 1, current_trace_status ());
Why "+ 1" ?
> + else
> + error (_("Unknown trace notification."));
What will be the upgrade path for new notifications?
Should gdb reply some sort of error to the remote?
> +}
--
Pedro Alves