This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] New method gdb.Frame.arch_name which return's the name of frame's architecture
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: gdb-patches at sourceware dot org, pmuldoon at redhat dot com
- Date: Fri, 11 Jan 2013 17:43:35 +0200
- Subject: Re: [RFC] New method gdb.Frame.arch_name which return's the name of frame's architecture
- References: <CAGyQ6gw4zq4NQhKQ+-Gzuma+=sLTvnuzi5J5tVnKTdHJMZX=NA@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 11 Jan 2013 06:56:22 -0800
> From: Siva Chandra <sivachandra@google.com>
> Cc: Phil Muldoon <pmuldoon@redhat.com>
>
> Attached is a patch which adds a new method 'arch_name' to the class
> gdb.Frame. This new method returns the name of the frame's
> architecture as a string value.
Thanks.
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -39,6 +39,9 @@ Lynx 178 PowerPC powerpc-*-lynx*178
>
> ** Python 3 is now supported (in addition to Python 2.4 or later)
>
> + ** New method 'arch_name' added to gdb.Frame class which returns
> + the name of the frame's architecture.
We describe the _state_ of GDB, not the actions which led to that
state. So it would be better to reword like this:
A new method 'arch_name' of the gdb.Frame class returns the name of
the frame's architecture.
> +@defun Frame.arch_name ()
> +Returns the name (string value) of the frame's architecture.
"Return", not "Returns", for consistency with other method
descriptions.
The documentation parts are OK with these changes.