This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] patch to refactor ppc64 specific code from ppc-linux-tdep


Ping?

Thanks,
Andreas

On 27.12.12 22:36, Andreas Tobler wrote:
> Hi all,
> 
> in order to avoid code duplication for the FreeBSD powerpc port I
> started to cut off common code from ppc-linux-tdep.c into a new file to
> be used for FreeBSD and GNU/Linux PowerPC 64-bit. The file name is open
> so far. Better namings are welcome.
> 
> Attached my first attempt, tested on GNU/Linux ppc64, Fedora 17 and on
> x86_64-*freebsd* with --eanble-targets=all. On the Linux side I do not
> see any regression.
> So far I have only covered functions which I can use on FreeBSD
> powerpc64. There might be others too but I do not see any for now.
> 
> I'd appreciate comments, corrections.
> 
> TIA,
> Andreas
> 
> 2012-12-19  Andreas Tobler  <andreast@neon.andreas.nets>
> 
> 	* Makefile.in (ALL_TARGET_OBS): Add new file ppc64-common-tdep.o
> 	(HFILES_NO_SRCDIR): Likewise.
> 	(ALLDEPFILES): Likewise.
> 	* configure.tgt: Add new file for powerpc-linux.
> 	* ppc64-common-tdep.h: New file.
> 	* ppc64-common-tdep.c New file.
> 	(insn_d, insn_ds, insn_xfx, read_insn)
> 	(insns_match_pattern, insn_d_field, insn_ds_field)
> 	(ppc64_desc_entry_point): Move from ppc-linux-tdep.c to here.
> 	(PPC64_STANDARD_LINKAGE1_LEN, PPC64_STANDARD_LINKAGE2_LEN)
> 	(PPC64_STANDARD_LINKAGE2_LEN): Likewise and use ARRAY_SIZE macro.
> 	(ppc64_standard_linkage1_target, ppc64_standard_linkage2_target)
> 	(ppc64_standard_linkage3_target, ppc64_skip_trampoline_code): Move
> 	from ppc-linux-tdep.c to here.
> 	(ppc64_convert_from_func_ptr_addr): Rename it from
> 	ppc64_linux_convert_from_func_ptr_addr to
> 	ppc64_convert_from_func_ptr_addr and move it from ppc-linux-tdep.c to
> 	here.
> 	* ppc-linux-tdep.c: Include ppc64-common-tdep.h.
> 	Removed above functions.
> 	(ppc_linux_init_abi): Rename
> 	ppc64_linux_convert_from_func_ptr_addr to
> 	ppc64_linux_convert_from_func_ptr_addr.
> 
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]