This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] GDBserver aarch64 support.
- From: Pedro Alves <palves at redhat dot com>
- To: Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 04 Feb 2013 17:59:54 +0000
- Subject: Re: [PATCH] GDBserver aarch64 support.
- References: <510FF2A2.4020808@arm.com>
On 02/04/2013 05:40 PM, Marcus Shawcroft wrote:
>>> + /* Find the entry that matches the ADDR and CTRL. */
>>> + for (i = 0; i < num_regs; ++i)
>>> + if (dr_addr_p[i] == addr && dr_ctrl_p[i] == ctrl)
>>> + {
>>> + gdb_assert (dr_ref_count[i] != 0);
>>> + break;
>>
>> "break" after gdb_assert is dead code.
>
> This one matters, it is required in order to terminate the loop early.
Right. I don't know what I was thinking.
> 2013-02-04 Jim MacArthur <jim.macarthur@arm.com>
> Marcus Shawcroft <marcus.shawcroft@arm.com>
> Nigel Stephens <nigel.stephens@arm.com>
> Yufeng Zhang <yufeng.zhang@arm.com>
>
> gdb/
>
> * configure.tgt (aarch64*-*-linux*): Set build_gdbserver=yes.
>
> gdb/gdbserver/
>
> * Makefile.in (clean): Remove aarch64.c and aarch64-without-fpu.c
Missing period at end of sentence.
> (aarch64.c, aarch64-without-fpu.c): New targets.
> * configure.srv (aarch64*-*-linux*): New.
> * linux-aarch64-low.c: New file.
Excellent. This is OK.
--
Pedro Alves