This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH] Fix layout in aarch64-tdep.c
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Marcus Shawcroft'" <marcus dot shawcroft at arm dot com>, <gdb-patches at sourceware dot org>
- Date: Tue, 5 Feb 2013 14:03:57 +0100
- Subject: RE: [PATCH] Fix layout in aarch64-tdep.c
- References: <511101D1.1000903@arm.com>
All changes that simply remove the additional entry in the ARI
web page, and generated a "New ARI warning" message,
can be checked in as obvious.
Thus, please do commit this fix,
the best would be to mention ARI rule in the ChangeLog entry.
Something like
* aarch64-tdep.c (aarch64_analyze_prologue): ARI fix:
Refactor if statement to avoid trailing || operator.
Pierre Muller
as ARI maintainer.
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Marcus Shawcroft
> Envoyé?: mardi 5 février 2013 13:58
> À?: gdb-patches@sourceware.org
> Objet?: [PATCH] Fix layout in aarch64-tdep.c
>
> This patch fixes the gripe:
>
> 0a1,2
> > gdb/aarch64-tdep.c:776: code: OP eol: Do not use &&, or || at the end
> of a line
> gdb/aarch64-tdep.c:776: pv_add_constant
> (regs[rn], imm)) ||
>
>
> OK?
>
> /Marcus
>
> ChangeLog:
>
>
> * aarch64-tdep.c (aarch64_analyze_prologue): Refactor if statement
> with trailing || operator.