This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch][python] 2 of 5 - Frame filter MI code changes.


>> Right now, though. -stack-list-frames doesn't take any options.
>> I think it would be better if commands like this were converted to use
>> mi_getopt instead of doing the parsing by hand.
>> So I suggest having all the functions use a short option name.
>> 
>> I think the changes like in -stack-list-locals are strange, too, in that
>> they make options order-dependent.  This will be surprising to users.

Phil> I spent the last couple of weeks trying to fix this, and I have
Phil> reached a dead end with your review requirements.

Ok.

Phil> This is all somewhat tangential to the frame filters patch.  While I
Phil> do not mind fixing issues as I go, this is becoming an issue far more
Phil> contentious than the patch content.

Phil> What do you think we should do?

For commands like -stack-list-frames, where the additions are new, use
mi_getopt.  For existing commands with bogus argument handling, just do
whatever you can that makes sense.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]