This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: New ARI warning Thu Feb 14 01:59:49 UTC 2013 in -D 2013-02-14-gmt
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Date: Thu, 14 Feb 2013 10:59:13 +0100
- Subject: RE: New ARI warning Thu Feb 14 01:59:49 UTC 2013 in -D 2013-02-14-gmt
- References: <20130214015949.GA27541@sourceware.org>
> 320a314,315
> > gdb/i386-linux-nat.c:836: comment: GNU/Linux: Do not use 'Linux',
instead
> use 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate between the two (this test assumes that word 'Linux' appears
> on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-linux-nat.c:836: this compatible with older Linux kernels
too.
> */
> > gdb/i386-linux-nat.c:992: comment: GNU/Linux: Do not use 'Linux',
instead
> use 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate between the two (this test assumes that word 'Linux' appears
> on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-linux-nat.c:992:/* Get Linux/x86 target description from running
> target. */
These two warnings are just comments moved from
i386-nat.c to i386-linux-nat.c
which seems like a good move indeed.
Moreover, the warning triggers because
'Linux kernels' in not accepted :(
It's easy to allow the plural by changing
pattern:
< && !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
---
> && !/(^|[^_[:alnum:]])Linux kernels?([^_[:alnum:]]|$)/ \
But the discussion about removing the 'Linux comment' rule
altogether didn't really come to a definitive conclusion....
Pierre Muller
as ARI maintainer
> 333,334d327
> < gdb/i386-nat.c:225: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-nat.c:225: on fork/vfork/clone. Newer Linux kernels
> create such tasks with
> < gdb/i386-nat.c:230: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-nat.c:230: process to be compatible with the older Linux
> kernels.