This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it.

Pedro> Yeah...  It'd be an easier sell if libiberty wasn't such a
Pedro> kitchen sink.  I know that parts of libiberty would be problematic
Pedro> for the Windows CE (I know, it's rotten by now), not sure about
Pedro> other ports.

I suppose my main concern here is that the gdb/gdbserver unification
project will end up needing to reimplement chunks of libiberty.
But that would be a bad result, since libiberty already exists.

I don't really care so much about this particular function.
It is small, it doesn't really matter.  The xstrndup name is better
(IMO), but unimportantly so.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]