This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Get trace file name when using 'target tfile'


On 14/02/13 22:02:13, Eli Zaretskii wrote:
> Date: Thu, 14 Feb 2013 15:49:30 +0000
> From: "Abid, Hafiz" <hafiz_abid@mentor.com>
> CC: Yao Qi <yao@codesourcery.com>, <gdb-patches@sourceware.org>,
> 	<marc.khouzam@ericsson.com>
>
> 1. Renamed "from_file" field to "filename". Use explicit NULL(or
> non-NULL) check against it.
> 2. Added a test case for -trace-struct command.
> 3. Added NEWS entry.
>
> How does it look?

OK, but:

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -150,6 +150,9 @@ show filename-display
> ** The response to breakpoint commands and breakpoint async records
> includes an "installed" field containing a boolean state about each
> non-pending tracepoint location is whether installed on target or not.
> + ** Output of the "-trace-status" command includes a "trace-file" field
> + containing the name of the trace file being examined. This field is
^^
Two spaces between sentences, please.


The documentation parts are OK with that change. Thanks.


Thanks Eli and Pedro for review. I committed after making the change suggested by Eli.


Regards,
Abid


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]