This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: remove the symtab "last resort" hack


On 1/15/13 8:51 AM, Tom Tromey wrote:
> Two functions in symtab.c have long had a "last resort" branch where
> they extend a search "just in case".  That is, if the search was
> requested for STATIC_BLOCK, and fails, then the functions will search
> GLOBAL_BLOCK; and vice versa.
> 
>>From what I can tell, this code doesn't serve any purpose.  It is there
> to defend against imagined gdb bugs elsewhere.

Yes, this was part of the ill-advised mass merge of HP changes for WDB.
 It may very well have come into play as part of making GDB work
with HP's aCC, or just as likely have been an attempt to fix another
bug.  But we don't want it there in any case.

(Another reminder as to why we want separate patches that can be
reviewed individually...)

Stan
stan@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]