This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch+doc 1/2] filename-display: 1->4 options {inferior,libs}{,-sepdebug}


> Date: Fri, 15 Feb 2013 21:25:36 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -123,9 +123,20 @@ show print type typedefs
>    The default is to show them.
>  
>  set filename-display basename|relative|absolute
> +set filename-display executable basename|relative|absolute
> +set filename-display libraries basename|relative|absolute
> +set filename-display executable-with-separate-debug-info basename|relative
> +							 |absolute
> +set filename-display libraries-with-separate-debug-info basename|relative
> +							|absolute
>  show filename-display
> +show filename-display executable
> +show filename-display libraries
> +show filename-display executable-with-separate-debug-info
> +show filename-display libraries-with-separate-debug-info
>    Control the way in which filenames is displayed.
> -  The default is "relative", which preserves previous behavior.
> +  The default is "relative" for all the options, which preserves previous
> +  behavior.

OK for this part.

> +@item set filename-display executable @{relative|basename|absolute@}
> +Set how to display filenames coming from the inferior executable, as set by the
> +@ref{file command}.  Inferior executable has to use embedded debug info as is
> +usually found in binaries compiled by @value{GDBN} user.

Here and elsewhere, I think, instead of a separate sentence saying "FOO
has to use BAR debug info", it is better to say "... when FOO uses BAR
debug info" in the same sentence.  For example:

  Set how to display filenames coming from the inferior executable, as
  set by the @ref{file command}, when the inferior executable uses
  embedded debug info as found in binaries compiled normally.

Otherwise, OK.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]