This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] remote, btrace: add branch tracing protocol to Qbtrace packet
- From: Eli Zaretskii <eliz at gnu dot org>
- To: markus dot t dot metzger at intel dot com
- Cc: jan dot kratochvil at redhat dot com, gdb-patches at sourceware dot org, markus dot t dot metzger at gmail dot com, markus dot t dot metzger at intel dot com
- Date: Fri, 22 Feb 2013 17:51:31 +0200
- Subject: Re: [rfc] remote, btrace: add branch tracing protocol to Qbtrace packet
- References: <1361546562-26827-1-git-send-email-markus.t.metzger@intel.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: markus.t.metzger@intel.com
> Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com, Markus Metzger <markus.t.metzger@intel.com>
> Date: Fri, 22 Feb 2013 16:22:42 +0100
>
> gdb/doc/gdb.texinfo | 10 +++++++---
> gdb/gdbserver/server.c | 6 +++---
> gdb/remote.c | 4 ++--
> 3 files changed, 12 insertions(+), 8 deletions(-)
The documentation part is OK, with one comment:
>> +@item Qbtrace:@var{method}
> +Enable branch tracing for the current thread using the @var{method}
> +branch trace recording method.
I would rephrase slightly:
Enable branch tracing for the current thread using the specified
@var{method} for branch trace recording.