This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] record: add "record function-call-history" command
On Fri, 22 Feb 2013 13:17:17 +0100, markus.t.metzger@intel.com wrote:
> * target.c (target_call_history, target_call_history_from,
> target_call_history_range): New.
> * target.h (target_ops) <to_call_history, to_call_history_from,
> to_call_history_range>: New fields.
> (target_call_history, target_call_history_from,
> target_call_history_range): New declaration.
> * record.c (get_call_history_modifiers, cmd_record_call_history,
> get_context_size, record_call_history_size): New.
> (_initialize_record): Add the "record function-call-history" command.
> Add "set/show record function-call-history-size" commands.
> * record.h (record_print_flag): New.
OK for check-in with the rest of patchset.
> --- a/gdb/record.h
> +++ b/gdb/record.h
> @@ -32,6 +32,13 @@ extern struct cmd_list_element *set_record_cmdlist;
> extern struct cmd_list_element *show_record_cmdlist;
> extern struct cmd_list_element *info_record_cmdlist;
>
> +/* A list of flags specifying what record target methods should print. */
> +enum record_print_flag
> + {
> + /* Print the source file and line (if applicable). */
> + record_print_src_line = (1 << 0)
> + };
This could be indented:
enum record_print_flag
{
/* Print the source file and line (if applicable). */
record_print_src_line = (1 << 0)
};
(There are many such cases how you wrote it in current GDB.)
Thanks,
Jan