This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Check trace data from trace file


On 02/27/2013 11:23 PM, Pedro Alves wrote:
I'd prefer keeping it actually.  It's there to disambiguate with
the case of the new line of text being a continuation of the previous
context, that happens to end up on a new line just because that's how the
text flowed.  Like:

  	(foo_function_foo): New blah foo bar yum foo foo foo.
         Call use_collected_data once on the live target.

What called "use_collected_data"? foo_function_foo, or the top level?

I grep'ed ChangeLog in gdb/testuite, and find "top level" has been used many times before. I didn't notice this.



Otherwise this version is OK. Thanks.

Committed with the changelog fix.


--
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]