This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [ada RFA] Don't repetively search static/global blocks
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 5 Mar 2013 13:59:53 -0500
- Subject: Re: [ada RFA] Don't repetively search static/global blocks
- References: <yjt2hakpk7ra.fsf@ruffy2.mtv.corp.google.com>
> Joel, can you test this on Ada?
Of course! Just did on x86_64-linux, and no regression found.
> 2013-03-05 Doug Evans <dje@google.com>
>
> * ada-lang.c (ada_lookup_sumbol_list_worker): New function, contents
> of old ada_lookup_symbol_list. In !full_search case, don't
> search superblocks.
> (ada_lookup_symbol_list): Delete arg full_search, all callers
> updated. Call ada_lookup_sumbol_list_worker.
> (ada_iterate_over_symbols): Call ada_lookup_sumbol_list_worker.
> * ada-lang.h (ada_lookup_symbol_list): Update.
> * language.h (language_defn): Update comment for
> la_iterate_over_symbols.
> * linespec.c (iterate_over_file_blocks): New function.
> (iterate_over_all_matching_symtabs): Call it.
> (lookup_prefix_sym): Ditto.
> (get_current_search_block): New function.
> (get_search_block): Delete.
> (find_label_symbols): Call get_current_search_block.
> (add_matching_symbols_to_info): Call iterate_over_file_blocks.
> * symtab.c (iterate_over_symbols): Don't search superblocks.
--
Joel