This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] cleanup: while (isspace) -> skip_spaces{,_const}


On 03/07/2013 08:39 AM, Pedro Alves wrote:

This now continues forward even if *addr_exp is '\0',
while before the patch it  didn't.

Yes, that's right, it is a subtle change that I missed because...


And it seems to be we'll now reach that last error in that
case, while we wouldn't before.  Can we trigger that with
"info register rip    ", say?

...it has no effect. In execute_command, top.c:461, the command parser strips trailing whitespace.


I can add a check for *addr_exp == '\0' again, if you'd like.

Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]