This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Change trace buffer size(v5)
- From: Yao Qi <yao at codesourcery dot com>
- To: "Abid, Hafiz" <hafiz_abid at mentor dot com>
- Cc: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>, <stan at codesourcery dot com>, <eliz at gnu dot org>
- Date: Fri, 8 Mar 2013 23:25:47 +0800
- Subject: Re: [patch] Change trace buffer size(v5)
- References: <1362755693.30327.1@abidh-ubunto1104>
On 03/08/2013 11:14 PM, Abid, Hafiz wrote:
> Sorry, I had already applied the patch before I saw your email.
>
Never mind.
>>> >>Document
>>> >> trace-buffer-size set and show commands.
>> >
>> >The indentation looks odd here.
>> >
The doc/ChangeLog is correct. Looks it was caused by copying changelog
entry into the mail.
>>> >>+ set_trace_buffer_size, NULL,
>>> >>+ &setlist, &showlist);
>>> >>+
>> >
>> >Indentation looks odd to me.
> If you can let me know which portion is wrong then it will help me.
The patch below fixes the problem I mentioned. Committed as it is obvious.
--
Yao (éå)
gdb/
2013-03-08 Yao Qi <yao@codesourcery.com>
* tracepoint.c (_initialize_tracepoint): Indent the code.
Index: tracepoint.c
===================================================================
RCS file: /cvs/src/src/gdb/tracepoint.c,v
retrieving revision 1.284
diff -u -r1.284 tracepoint.c
--- tracepoint.c 8 Mar 2013 15:06:35 -0000 1.284
+++ tracepoint.c 8 Mar 2013 15:18:43 -0000
@@ -5423,14 +5423,14 @@
&showlist);
add_setshow_zuinteger_unlimited_cmd ("trace-buffer-size", no_class,
- &trace_buffer_size, _("\
+ &trace_buffer_size, _("\
Set requested size of trace buffer."), _("\
Show requested size of trace buffer."), _("\
Use this to choose a size for the trace buffer. Some targets\n\
may have fixed or limited buffer sizes. A value of -1 disables\n\
any attempt to set the buffer size and lets the target choose."),
- set_trace_buffer_size, NULL,
- &setlist, &showlist);
+ set_trace_buffer_size, NULL,
+ &setlist, &showlist);
add_setshow_string_cmd ("trace-user", class_trace,
&trace_user, _("\