This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Accelerate filenames matching
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Doug Evans <dje at google dot com>
- Date: Tue, 12 Mar 2013 08:19:12 -0700
- Subject: Re: [patch] Accelerate filenames matching
- References: <20130312132640.GA21810@host2.jankratochvil.net>
> gdb/
> 2013-03-12 Doug Evans <dje@google.com>
> Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * dwarf2read.c (dw2_map_symtabs_matching_filename): Put continue after
> any successful compare_filenames_for_search or FILENAME_CMP.
> * psymtab.c (partial_map_symtabs_matching_filename): Likewise.
> * symtab.c (iterate_over_some_symtabs): Likewise.
Do we want this patch for 7.6?
> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
> index faee1a8..47e4958 100644
> --- a/gdb/dwarf2read.c
> +++ b/gdb/dwarf2read.c
> @@ -3079,6 +3079,7 @@ dw2_map_symtabs_matching_filename (struct objfile *objfile, const char *name,
> if (dw2_map_expand_apply (objfile, per_cu, name, real_path,
> callback, data))
> return 1;
> + continue;
> }
>
> /* Before we invoke realpath, which can get expensive when many
> @@ -3093,6 +3094,7 @@ dw2_map_symtabs_matching_filename (struct objfile *objfile, const char *name,
> if (dw2_map_expand_apply (objfile, per_cu, name, real_path,
> callback, data))
> return 1;
> + continue;
> }
>
> if (real_path != NULL)
> @@ -3105,6 +3107,7 @@ dw2_map_symtabs_matching_filename (struct objfile *objfile, const char *name,
> if (dw2_map_expand_apply (objfile, per_cu, name, real_path,
> callback, data))
> return 1;
> + continue;
> }
> }
> }
> diff --git a/gdb/psymtab.c b/gdb/psymtab.c
> index 2965e9f..7b118c5 100644
> --- a/gdb/psymtab.c
> +++ b/gdb/psymtab.c
> @@ -183,6 +183,7 @@ partial_map_symtabs_matching_filename (struct objfile *objfile,
> if (partial_map_expand_apply (objfile, name, real_path,
> pst, callback, data))
> return 1;
> + continue;
> }
>
> /* Before we invoke realpath, which can get expensive when many
> @@ -196,6 +197,7 @@ partial_map_symtabs_matching_filename (struct objfile *objfile,
> if (partial_map_expand_apply (objfile, name, real_path,
> pst, callback, data))
> return 1;
> + continue;
> }
>
> /* If the user gave us an absolute path, try to find the file in
> @@ -209,6 +211,7 @@ partial_map_symtabs_matching_filename (struct objfile *objfile,
> if (partial_map_expand_apply (objfile, name, real_path,
> pst, callback, data))
> return 1;
> + continue;
> }
> }
> }
> diff --git a/gdb/symtab.c b/gdb/symtab.c
> index c0e5884..c9dcf7a 100644
> --- a/gdb/symtab.c
> +++ b/gdb/symtab.c
> @@ -212,6 +212,7 @@ iterate_over_some_symtabs (const char *name,
> {
> if (callback (s, data))
> return 1;
> + continue;
> }
>
> /* Before we invoke realpath, which can get expensive when many
> @@ -224,6 +225,7 @@ iterate_over_some_symtabs (const char *name,
> {
> if (callback (s, data))
> return 1;
> + continue;
> }
>
> /* If the user gave us an absolute path, try to find the file in
> @@ -239,6 +241,7 @@ iterate_over_some_symtabs (const char *name,
> {
> if (callback (s, data))
> return 1;
> + continue;
> }
> }
> }
--
Joel