This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 11/15] Write tsv definition in CTF and read

From: Tom Tromey <tromey at redhat dot com>
To: Yao Qi <yao at codesourcery dot com>
Cc: <gdb-patches at sourceware dot org>
Date: Tue, 12 Mar 2013 13:56:14 -0600
Subject: Re: [PATCH v3 11/15] Write tsv definition in CTF and read
References: <1362800844-27940-1-git-send-email-yao@codesourcery.com> <1362800844-27940-12-git-send-email-yao@codesourcery.com>

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> 2013-03-08  Yao Qi  <yao@codesourcery.com>
Yao> 	* ctf.c (CTF_EVENT_ID_TSV_DEF): New macro.
Yao> 	(ctf_save_metadata_header): Define new type alias in
Yao> 	metadata.
Yao> 	(ctf_write_header): Define new event type "tsv_def".
Yao> 	(ctf_write_uploaded_tsv): Write TSV to CTF.
Yao> 	(ctf_read_tsv): New.
Yao> 	(ctf_open): Call ctf_read_tsv and
Yao> 	merge_uploaded_trace_state_variables.
Yao> 	* tracepoint.c (get_uploaded_tsv): Remove 'static'.
Yao> 	* tracepoint.h (get_uploaded_tsv): Declare.

Yao> +   3. Uploaded trace variables.  Event "tsv_def" is defined in metata,

Typo, "metadata".

Otherwise this looks ok to me.

Tom

References:
- [PATCH v3 00/15] CTF Support
  - From: Yao Qi
- [PATCH v3 11/15] Write tsv definition in CTF and read
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]