This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][python] 2 of 5 - Frame filter MI code changes.
On 12/03/13 20:52, Phil Muldoon wrote:
> On 12/03/13 20:43, Tom Tromey wrote:
>
>> Phil> + /* Run the inbuilt backtrace if there are no filters registered, or
>> Phil> + if there was an error in the Python backtracing output, or if
>> Phil> + frame-filters are disabled. */
>> Phil> + if (! frame_filters || raw_arg || result == PY_BT_ERROR
>> Phil> + || result == PY_BT_NO_FILTERS)
>>
>> It seems to me that the PY_BT_ERROR case should not be here, since the
>> MI client could get a partially filtered trace followed by the normal
>> trace.
>
> Yeah you are right. It's a pain to figure out what to do here. I suspect in
> MI case just abandon the trace.
I looked at this in a little more detail this morning.
apply_frame_filter in py-framefilter.c, will still try to print the
whole backtrace if it errors on one frame. It will print the error
message and move onto the next frame. So PY_BT_ERROR is wrong in all
cases, both in MI and CLI. I'll fix this up. Good spot. So bear
this in mind when you (or anyone) reviews the CLI case. It is fixed
locally.
Cheers
Phil