This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [COMMIT PATCH] More invalid pointer to pointer conversions.
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 13 Mar 2013 11:38:12 -0600
- Subject: Re: [COMMIT PATCH] More invalid pointer to pointer conversions.
- References: <20130313164801.25932.31237.stgit@brno.lan>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> I think the ada_decode_symbol change is perhaps the one that could be
Pedro> surprising.
The obj_section removal series tripped over this too :)
Pedro> With that out of the way, I think the patch ends up being pretty
Pedro> obvious.
I agree, looks good to me.
Pedro> - displacement = strtol (tmp, (char **) &tmp, 10);
Pedro> + displacement = strtol (tmp, &endp, 10);
Pedro> + tmp = endp;
I saw this in Keith's patch, too, and I was wondering if we should have
a strtol_const convenience function.
Tom