Re: [patch, simulator] Fix sim_command_completer arguments.

[Mike Frysinger <vapier at gentoo dot org>]

On Friday 15 March 2013 13:31:59 Steve Ellcey wrote:
> My build of gdb and sim have recently started failing with:
> 
> /local/home/sellcey/nightly2/src/gdb/gdb/remote-sim.c: In function
> '_initialize_remote_sim':
> /local/home/sellcey/nightly2/src/gdb/gdb/remote-sim.c:1323: error: passing
> argument 2 of 'set_cmd_completer' from incompatible pointer type
> /local/home/sellcey/nightly2/src/gdb/gdb/command.h:161: note: expected
> 'struct VEC_char_ptr * (*)(struct cmd_list_element *, const char *, const
> char *)' but argument is of type 'struct VEC_char_ptr * (*)(struct
> cmd_list_element *, char *, char *)'
> 
> I didn't see any change in gdb/sim that might be causing this but I am
> building with the latest (ToT) GCC and I think a change there might have
> caused GCC to start catching this discrepency in argument types.  I would
> like to fix it by adding the 'const' modifier to the sim_command_completer
> text and word arguments so that its argument types match
> filename_completer, expression_completer, etc.
> 
> Tested by building gdb and sim on mips-mti-elf.  I didn't test all the
> platforms that I modified but unless I made a typo there shouldn't be any
> problems.
> 
> OK to checkin?

OK
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.