This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] [testsuite] [gdbserver] comments only: "localhost"->"localhost:"


Hi,

I find the comments being patched below wrong, my observation is:

gdb/testsuite/lib/gdbserver-support.exp
	gdbserver_start
	# Extract the local and remote host ids from the target board struct.
	if [target_info exists sockethost] {
	    set debughost [target_info sockethost]
	} else {
	    set debughost "localhost:"
	}
gdb/testsuite/boards/native-gdbserver.exp
	set_board_info sockethost "localhost:"
gdb/testsuite/boards/native-extended-gdbserver.exp
	set_board_info sockethost "localhost:"
gdb/testsuite/boards/native-stdio-gdbserver.exp
	set_board_info sockethost "stdio"
	set_board_info gdb,socketport ""

I will check it in.


Thanks,
Jan


diff --git a/gdb/testsuite/config/gdbserver.exp b/gdb/testsuite/config/gdbserver.exp
index 25fcc15..1170930 100644
--- a/gdb/testsuite/config/gdbserver.exp
+++ b/gdb/testsuite/config/gdbserver.exp
@@ -61,8 +61,10 @@
 #
 #   set_board_info sockethost
 #	The name of the host computer whose socket is being used.
-#	Defaults to "localhost".  Note: old gdbserver requires 
+#	Defaults to "localhost:".  Note: old gdbserver requires 
 #	that you define this, but libremote/gdbserver does not.
+#	It is concatenated with gdb,socketport, therefore it needs a colon
+#	unless gdb,socketport is empty and not in use.
 #
 #   set_board_info gdb,socketport
 #	Port id to use for socket connection.  If not set explicitly,
diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp
index 79ecc5a..a899035 100644
--- a/gdb/testsuite/lib/gdbserver-support.exp
+++ b/gdb/testsuite/lib/gdbserver-support.exp
@@ -30,8 +30,10 @@
 #
 #   set_board_info sockethost
 #	The name of the host computer whose socket is being used.
-#	Defaults to "localhost".  Note: old gdbserver requires 
+#	Defaults to "localhost:".  Note: old gdbserver requires 
 #	that you define this, but libremote/gdbserver does not.
+#	It is concatenated with gdb,socketport, therefore it needs a colon
+#	unless gdb,socketport is empty and not in use.
 #
 #   set_board_info gdb,socketport
 #	Port id to use for socket connection.  If not set explicitly,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]