RE: New ARI warning Thu Mar 21 13:31:00 UTC 2013 in -D 2013-03-21-gmt

["Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>]

  This is the series of new warnings coming from 
the change ARI: Extend binary operator at EOL checks  

  Feel free to correct these ARI regressions,
obvious rule applies for straightforward changes.

Pierre Muller
as ARI maintainer


> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de GDB Administrator
> Envoyé : jeudi 21 mars 2013 14:31
> À : gdb-patches@sourceware.org
> Objet : New ARI warning Thu Mar 21 13:31:00 UTC 2013 in -D 2013-03-21-gmt
> 
> 2a3
> > gdb/ada-lang.c:2393: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/ada-lang.c:2393:        (1 << (srcBitsLeft >= HOST_CHAR_BIT ?
> HOST_CHAR_BIT : srcBitsLeft)) -
> 4a6
> > gdb/ada-lang.c:8625: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/ada-lang.c:8625:                                   valaddr +
> 47a50
> > gdb/buildsym.c:1146: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/buildsym.c:1146:	      linetablesize = sizeof (struct linetable) +
> 69a73,76
> > gdb/coff-pe-read.c:410: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/coff-pe-read.c:410:  secptr = (pe_header_offset + 4 + 20 +
> > gdb/coff-pe-read.c:554: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/coff-pe-read.c:554:      unsigned long func_rva = pe_as32 (erva +
> exp_funcbase +
> > gdb/coff-pe-read.c:672: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/coff-pe-read.c:672:  secptr = (pe_header_offset + 4 + 20 +
> > gdb/coffread.c:534: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/coffread.c:534:  stringtab_offset = symtab_offset +
> 161a169,170
> > gdb/cp-support.c:1180: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/cp-support.c:1180:  sym_return_val = xmalloc ((sym_return_val_size +
1)
> *
> > gdb/cp-valprint.c:384: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/cp-valprint.c:384:		obstack_next_free
> (&dont_print_statmem_obstack) -
> 163d171
> < gdb/ctf.c:223: regression: LITTLE_ENDIAN: Do not use LITTLE_ENDIAN,
> instead use BFD_ENDIAN_LITTLE
> gdb/ctf.c:223:			   BYTE_ORDER == LITTLE_ENDIAN ? ' :
');
> 164a173
> > gdb/dbxread.c:1246: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/dbxread.c:1246:  psymtab_include_list = (const char **) alloca
> (includes_allocated *
> 170a180
> > gdb/dcache.c:380: code: OP eol: Do not use &&, or || at the end of a
line
> gdb/dcache.c:380:	db = xmalloc (offsetof (struct dcache_block, data) +
> 204a215,218
> > gdb/dwarf2read.c:4995: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/dwarf2read.c:4995:  pst->n_global_syms = objfile->global_psymbols.next
-
> > gdb/dwarf2read.c:4997: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/dwarf2read.c:4997:  pst->n_static_syms = objfile->static_psymbols.next
-
> > gdb/dwarf2read.c:5423: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/dwarf2read.c:5423:  pst->n_global_syms = objfile->global_psymbols.next
-
> > gdb/dwarf2read.c:5425: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/dwarf2read.c:5425:  pst->n_static_syms = objfile->static_psymbols.next
-
> 286a301
> > gdb/hppa-tdep.c:429: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/hppa-tdep.c:429:	    = ui->table[index].region_start + 4 *
> 295a311,318
> > gdb/i386-tdep.c:5576: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/i386-tdep.c:5576:
I387_ST0_REGNUM
> (tdep) +
> > gdb/i386-tdep.c:5643: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/i386-tdep.c:5643:
I387_ST0_REGNUM
> (tdep) +
> > gdb/i386-tdep.c:5650: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/i386-tdep.c:5650:
I387_ST0_REGNUM
> (tdep) +
> > gdb/i386-tdep.c:5670: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/i386-tdep.c:5670:
I387_ST0_REGNUM
> (tdep) +
> > gdb/i386-tdep.c:5677: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/i386-tdep.c:5677:
I387_ST0_REGNUM
> (tdep) +
> > gdb/i386-tdep.c:5691: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/i386-tdep.c:5691:
I387_ST0_REGNUM
> (tdep) +
> > gdb/i386-tdep.c:5698: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/i386-tdep.c:5698:
I387_ST0_REGNUM
> (tdep) +
> > gdb/i386-tdep.c:5716: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/i386-tdep.c:5716:
I387_ST0_REGNUM
> (tdep) +
> 398a422,423
> > gdb/m2-valprint.c:278: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/m2-valprint.c:278:      if (TYPE_LENGTH (type) == 1 &&
> > gdb/m2-valprint.c:333: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/m2-valprint.c:333:	  if (TYPE_LENGTH (elttype) == 1 &&
> 417a443,444
> > gdb/mdebugread.c:2390: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/mdebugread.c:2390:  psymtab_include_list = (const char **) alloca
> (includes_allocated *
> > gdb/mdebugread.c:3094: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/mdebugread.c:3094:			    alloca
((includes_allocated *= 2)
> *
> 436a464
> > gdb/mips-linux-tdep.c:1018: code: OP eol: Do not use &&, or || at the
end
> of a line
> gdb/mips-linux-tdep.c:1018:			       ireg + regs->fp0 +
> 483a512
> > gdb/nto-procfs.c:1102: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/nto-procfs.c:1102:  argv = xmalloc (((strlen (allargs) + 1) /
(unsigned)
> 2 + 2) *
> 495a525
> > gdb/objc-lang.c:1456: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/objc-lang.c:1456:	  mlist = read_memory_unsigned_integer
> (class_str.methods +
> 496a527,528
> > gdb/opencl-lang.c:990: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/opencl-lang.c:990:	      memcpy (value_contents_writeable (ret)
+
> > gdb/p-valprint.c:106: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/p-valprint.c:106:		       extract_unsigned_integer (valaddr +
> embedded_offset +
> 503a536
> > gdb/ppc-linux-nat.c:897: code: OP eol: Do not use &&, or || at the end
of
> a line
> gdb/ppc-linux-nat.c:897:  regcache_raw_collect (regcache, regno, regs +
> 506a540,543
> > gdb/ppc-sysv-tdep.c:1508: code: OP eol: Do not use &&, or || at the end
of
> a line
> gdb/ppc-sysv-tdep.c:1508:
tdep-
> >ppc_gp0_regnum +
> > gdb/ppc-sysv-tdep.c:1549: code: OP eol: Do not use &&, or || at the end
of
> a line
> gdb/ppc-sysv-tdep.c:1549:
tdep-
> >ppc_gp0_regnum +
> > gdb/ppc-sysv-tdep.c:1927: code: OP eol: Do not use &&, or || at the end
of
> a line
> gdb/ppc-sysv-tdep.c:1927:		  convert_typed_floating ((const
bfd_byte *)
> writebuf +
> > gdb/ppc-sysv-tdep.c:1940: code: OP eol: Do not use &&, or || at the end
of
> a line
> gdb/ppc-sysv-tdep.c:1940:					  (bfd_byte
*) readbuf +
> 610a648
> > gdb/remote-sim.c:689: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/remote-sim.c:689:	 + strlen (') + strlen (gdb_sysroot) +
> 660a699,717
> > gdb/rs6000-tdep.c:2664: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2664:      status = regcache_raw_read (regcache, tdep-
> >ppc_fp0_regnum +
> > gdb/rs6000-tdep.c:2667: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2667:	status = regcache_raw_read (regcache, tdep-
> >ppc_fp0_regnum +
> > gdb/rs6000-tdep.c:2686: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2686:      regcache_raw_write (regcache, tdep-
> >ppc_fp0_regnum +
> > gdb/rs6000-tdep.c:2688: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2688:      regcache_raw_write (regcache, tdep-
> >ppc_fp0_regnum +
> > gdb/rs6000-tdep.c:2693: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2693:      regcache_raw_write (regcache, tdep-
> >ppc_fp0_regnum +
> > gdb/rs6000-tdep.c:2695: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2695:      regcache_raw_write (regcache, tdep-
> >ppc_fp0_regnum +
> > gdb/rs6000-tdep.c:2711: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2711:    status = regcache_raw_read (regcache, tdep-
> >ppc_vr0_regnum +
> > gdb/rs6000-tdep.c:2717: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2717:	status = regcache_raw_read (regcache, tdep-
> >ppc_fp0_regnum +
> > gdb/rs6000-tdep.c:2720: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2720:	  status = regcache_raw_read (regcache,
tdep-
> >ppc_vsr0_upper_regnum +
> > gdb/rs6000-tdep.c:2725: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2725:	status = regcache_raw_read (regcache, tdep-
> >ppc_fp0_regnum +
> > gdb/rs6000-tdep.c:2728: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2728:	  status = regcache_raw_read (regcache,
tdep-
> >ppc_vsr0_upper_regnum +
> > gdb/rs6000-tdep.c:2745: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2745:    regcache_raw_write (regcache, tdep-
> >ppc_vr0_regnum +
> > gdb/rs6000-tdep.c:2751: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2751:	regcache_raw_write (regcache,
tdep->ppc_fp0_regnum
> +
> > gdb/rs6000-tdep.c:2753: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2753:	regcache_raw_write (regcache, tdep-
> >ppc_vsr0_upper_regnum +
> > gdb/rs6000-tdep.c:2758: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2758:	regcache_raw_write (regcache,
tdep->ppc_fp0_regnum
> +
> > gdb/rs6000-tdep.c:2760: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:2760:	regcache_raw_write (regcache, tdep-
> >ppc_vsr0_upper_regnum +
> > gdb/rs6000-tdep.c:3561: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:3561:  from_xcoff_exec = info.abfd && info.abfd->format
==
> bfd_object &&
> > gdb/rs6000-tdep.c:3564: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:3564:  from_elf_exec = info.abfd && info.abfd->format ==
> bfd_object &&
> > gdb/rs6000-tdep.c:3588: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/rs6000-tdep.c:3588:	wordsize = info.bfd_arch_info->bits_per_word
/
> 690a748
> > gdb/solib-sunos.c:554: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/solib-sunos.c:554:  flag_addr = debug_addr + (CORE_ADDR) ((char *)
> &debug_copy.ldd_in_debugger -
> 798a857,858
> > gdb/tui/tui-regs.c:82: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-regs.c:82:      num_lines = (TUI_DATA_WIN-
> >detail.data_display_info.regs_content_count /
> > gdb/tui/tui-regs.c:127: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-regs.c:127:	    TUI_DATA_WIN-
> >detail.data_display_info.regs_column_count) -
> 809a870,872
> > gdb/tui/tui-stack.c:377: code: OP eol: Do not use &&, or || at the end
of
> a line
> gdb/tui/tui-stack.c:377:	      start_line = (item->locator.line_no -
> > gdb/tui/tui-win.c:750: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-win.c:750:	  else if ((first_win->generic.height +
> > gdb/tui/tui-win.c:766: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-win.c:766:	  else if ((first_win->generic.height +
> 811a875,882
> > gdb/tui/tui-win.c:1462: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-win.c:1462:	      ok = ((new_height +
> > gdb/tui/tui-win.c:1492: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-win.c:1492:	      ok = ((first_win->generic.height +
> > gdb/tui/tui-win.c:1498: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-win.c:1498:		  total_height = new_height +
> > gdb/tui/tui-win.c:1499: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-win.c:1499:		    (first_win->generic.height +
> > gdb/tui/tui-win.c:1523: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-win.c:1523:		    total_height = new_height +
> > gdb/tui/tui-win.c:1524: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-win.c:1524:		      second_win->generic.height +
> > gdb/tui/tui-win.c:1527: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-win.c:1527:		    total_height = new_height +
> > gdb/tui/tui-win.c:1528: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/tui/tui-win.c:1528:		      first_win->generic.height +
> 813a885
> > gdb/tui/tui-winsource.c:118: code: OP eol: Do not use &&, or || at the
end
> of a line
> gdb/tui/tui-winsource.c:118:	  sal.line = line_or_addr.u.line_no +
> 844a917
> > gdb/valops.c:3641: code: OP eol: Do not use &&, or || at the end of a
line
> gdb/valops.c:3641:  new_val = value_at_lazy (real_type, value_address
(argp)
> - top +
> 866a940
> > gdb/windows-nat.c:1010: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/windows-nat.c:1010:      base = (info.HighWord.Bits.BaseHi << 24) +
> 873a948
> > gdb/windows-nat.c:2722: code: OP eol: Do not use &&, or || at the end of
a
> line
> gdb/windows-nat.c:2722:      char *oldini = (char *) alloca (strlen
> (homedir) +
> 883a959,964
> > gdb/xcoffread.c:345: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/xcoffread.c:345:	xmalloc (sizeof (struct pending_stabs) +
> > gdb/xcoffread.c:354: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/xcoffread.c:354:	xrealloc ((char *) *stabvector, sizeof (struct
> pending_stabs) +
> > gdb/xcoffread.c:480: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/xcoffread.c:480:    (sizeof (struct linetable) +
> > gdb/xcoffread.c:2219: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/xcoffread.c:2219:  psymtab_include_list = (const char **) alloca
> (includes_allocated *
> > gdb/xcoffread.c:2619: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/xcoffread.c:2619:		  alloca ((includes_allocated *= 2) *
> > gdb/xcoffread.c:2955: code: OP eol: Do not use &&, or || at the end of a
> line
> gdb/xcoffread.c:2955:  stringtab_offset = symtab_offset +