This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add set/show display-linkname command
- From: Michael Eager <eager at eagerm dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 21 Mar 2013 13:55:41 -0700
- Subject: Re: [PATCH] Add set/show display-linkname command
- References: <5147BD81 dot 6000702 at eagercon dot com> <514B59C2 dot 4060806 at eagerm dot com> <83sj3oy1mb dot fsf at gnu dot org>
On 03/21/2013 12:49 PM, Eli Zaretskii wrote:
Date: Thu, 21 Mar 2013 12:04:34 -0700
From: Michael Eager <eager@eagerm.com>
Updated patch which fixes garbled output.
Thanks. This needs a suitable patch for the manual, to document this
new command, and also for NEWS.
Will do.
+ add_setshow_boolean_cmd ("display-linkname", class_support, &disp_linkname, _("\
+Set whether to display linkage name for functions."), _("\
+Show whether to display linkage name for functions."), NULL,
+ NULL,
+ show_disp_linkname,
+ &setlist, &showlist);
If this setting controls display of linkage name, why is the command
called "display-linkname" and not "display-linkage-name"?
Just saving keystrokes. I can change this.
Also, I think we need to explain what is a "linkage name" in the doc
string, because otherwise this doc string is 100% unhelpful, as it
says nothing at all about its purpose.
I'll update the patch with a more descriptive description.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077