This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Reset tracepoint step_count to 0 before set it action


On 03/24/13 22:09, Yao Qi wrote:
On 03/24/2013 07:32 PM, Hui Zhu wrote:
2013-03-24  Hui Zhu<hui@codesourcery.com>

    * breakpoint.c (do_map_commands_command): Reset step_count to 0
    if this is a tracepoint.
    * tracepoint.c (trace_actions_command): Ditto.

Looks both do_map_commands_command and trace_actions_command call check_tracepoint_command, so why don't set step_count in check_tracepoint_command?


I don't think this is a good place for put this reset code because this function will be call each time when user input a new line for actions.

Thanks,
Hui


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]