This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: one week to gdb-7.6 release?
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org, palves at redhat dot com, jan dot kratochvil at redhat dot com, ralf dot corsepius at rtems dot org, vapier at gentoo dot org, joel dot sherrill at oarcorp dot com
- Date: Mon, 25 Mar 2013 09:25:25 -0700
- Subject: Re: one week to gdb-7.6 release?
- References: <20130320160032 dot GC5447 at adacore dot com> <83vc8myoyb dot fsf at gnu dot org> <83ehf64cfs dot fsf at gnu dot org> <20130323162534 dot GI5447 at adacore dot com> <834ng23soj dot fsf at gnu dot org> <20130325151825 dot GJ5447 at adacore dot com> <83k3ov1mo0 dot fsf at gnu dot org>
> But then why do we need an implementation in posix-hdep.c at all?
I did not mean to say that we do need an implementation in posix-hdep,
just saying that we might someday in the future - and if we do, a
comment explaining the currrent implemention would help the next person
looking at it.
> The
> code in main.c already does
>
> #ifdef __MINGW32__
> /* On Windows, argv[0] is not necessarily set to absolute form when
> GDB is found along PATH, without which relocation doesn't work. */
> gdb_program_name = windows_get_absolute_argv0 (argv[0]);
> #else
> gdb_program_name = xstrdup (argv[0]);
> #endif
>
> Is moving that to posix-hdep.c just to avoid an ifdef?
The main purpose is to move the code away out of windows-nat, which
is only linked in native debuggers, not cross ones - so that building
a cross debugger hosted on Windows will work again. Basically, your
new function is really only dependent on the host, whereas the -nat
file makes the assumption that host & target are Windows.
--
Joel