This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Simulator dv-sockser.o patch testing
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Joel Sherrill <joel dot sherrill at oarcorp dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 25 Mar 2013 23:12:37 -0400 (EDT)
- Subject: Re: Simulator dv-sockser.o patch testing
- References: <514FB8F2 dot 9060702 at oarcorp dot com>
On Sun, 24 Mar 2013, Joel Sherrill wrote:
> The only discrepancy in the make check summary was that
> WITH Mike's patch cris-elf with --enable-sim-hardware has this:
>
> === sim Summary ===
> # of expected passes 304
> # of untested testcases 136
>
> In the 7.5.91 log, the 136 was 170.
The last time HEAD built, without --enable-sim-hardware there
was:
# of expected passes 304
# of untested testcases 170
(no C compiler installed, hence the untested cases.)
> I know absolutely nothing about cris and only ran this because
> the configure file changed after running autoconf. Nothing specific
> to the cris was changed. This could be something else going on.
I guess so. Nothing special about CRIS. Grep is your friend:
src/sim $ grep SIM_AC_OPTION_HARDWARE */configure.ac
bfin/configure.ac:SIM_AC_OPTION_HARDWARE(yes,,\
cris/configure.ac:SIM_AC_OPTION_HARDWARE(no,,rv cris)
frv/configure.ac:SIM_AC_OPTION_HARDWARE(always,"","")
iq2000/configure.ac:SIM_AC_OPTION_HARDWARE(always,"","")
lm32/configure.ac:SIM_AC_OPTION_HARDWARE(yes,,lm32cpu lm32timer lm32uart)
m32r/configure.ac:SIM_AC_OPTION_HARDWARE(always,"","")
m68hc11/configure.ac:SIM_AC_OPTION_HARDWARE($hw_enabled,$hw_devices,$hw_extra_devices)
mips/configure.ac:SIM_AC_OPTION_HARDWARE($hw_enabled,$hw_devices,$hw_extra_devices)
mn10300/configure.ac:SIM_AC_OPTION_HARDWARE(yes,,mn103cpu
mn103int mn103tim mn103ser mn103iop)
mn10300/configure.ac:SIM_AC_OPTION_HARDWARE(always,"","")
sh64/configure.ac:SIM_AC_OPTION_HARDWARE(always,"","")
That is, it's the only sim where the default config is "no": "no
hardware enabled by default". If that number *decreases* due to
a patch supposed to *enable* things, the patch seems wrong.
> As far as I can tell, Mike's patch is an improvement over mine
> and what was in 7.5.91. If he regenerates the configure scripts
> that need it, I would be perfectly happy with his patch being
> applied.
>
> This is the set of files which were touched by his patch or
> regenerated in my tree:
>
> # modified: sim/bfin/configure
> # modified: sim/common/acinclude.m4
> # modified: sim/cris/configure
> # modified: sim/frv/configure
> # modified: sim/iq2000/configure
> # modified: sim/lm32/configure
> # modified: sim/m32r/configure
> # modified: sim/m68hc11/configure
> # modified: sim/mips/configure
> # modified: sim/mn10300/configure
> # modified: sim/sh64/configure
>
> Mike, can you commit yours? Please. :)
First, please look into why the above number changes.
brgds, H-P