This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: "set record instruction-history" ?
- From: Pedro Alves <palves at redhat dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Tue, 26 Mar 2013 11:15:57 +0000
- Subject: Re: "set record instruction-history" ?
- References: <51507403 dot 6030208 at redhat dot com> <A78C989F6D9628469189715575E55B2307BA7E4F at IRSMSX102 dot ger dot corp dot intel dot com> <51508D60 dot 6040906 at redhat dot com> <A78C989F6D9628469189715575E55B2307BA822E at IRSMSX102 dot ger dot corp dot intel dot com>
On 03/26/2013 07:46 AM, Metzger, Markus T wrote:
> Shouldn't we map 0 to INT_MAX before committing the new value?
That's already done for us before this function is reached, by the
set/show machinery. "commit" here refers to copying the set/show
command's control variable value to the real setting variable
(record_(call|insn)_history_size).
> The functionality should be covered by the gdb.btrace test suite. Do you want
> to commit your patch or do you want me to test and then commit it?
Could you test and report back please? I believe my laptop's cpu is
one of those where branch tracing is borked and ended up disabled.
...
(gdb) record btrace
Target does not support branch tracing.
(gdb) testcase ../../../src/gdb/testsuite/gdb.btrace/enable.exp completed in 1 seconds
Running ../../../src/gdb/testsuite/gdb.btrace/function_call_history.exp ...
testcase ../../../src/gdb/testsuite/gdb.btrace/function_call_history.exp completed in 0 seconds
Running ../../../src/gdb/testsuite/gdb.btrace/instruction_history.exp ...
testcase ../../../src/gdb/testsuite/gdb.btrace/instruction_history.exp completed in 0 seconds
=== gdb Summary ===
Thanks,
--
Pedro Alves