This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Simulator dv-sockser.o patch testing


On Tue, 26 Mar 2013, Joel Sherrill wrote:
> On 3/25/2013 10:22 PM, Hans-Peter Nilsson wrote:
> > On Mon, 25 Mar 2013, Hans-Peter Nilsson wrote:
> > > That is, it's the only sim where the default config is "no": "no
> > > hardware enabled by default".  If that number *decreases* due to
> > > a patch supposed to *enable* things, the patch seems wrong.
> > Oops: it's the number of *untested* cases that decrease when
> > enabling default-disabled hardware (yes, I do test and account
> > for that in the test-suite)... *blush*
> >
> > So ignore my previous post while I remove my foot from my mouth.
> It is really complicated and a lot of details. No apology needed. :)
>
> Does Mike's patch look ok based upon my testing?

Dunno, there was a bit of churn there and it wasn't clear what
the intent was, but as Mike has the required rights no review is
required AFAIK.

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]