This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Simulator dv-sockser.o patch testing
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Joel Sherrill <joel dot sherrill at oarcorp dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 26 Mar 2013 13:49:20 -0400 (EDT)
- Subject: Re: Simulator dv-sockser.o patch testing
- References: <514FB8F2 dot 9060702 at oarcorp dot com> <alpine dot BSF dot 2 dot 02 dot 1303252303190 dot 97353 at arjuna dot pair dot com> <alpine dot BSF dot 2 dot 02 dot 1303252318080 dot 4293 at arjuna dot pair dot com> <5151A8B4 dot 8000201 at oarcorp dot com>
On Tue, 26 Mar 2013, Joel Sherrill wrote:
> On 3/25/2013 10:22 PM, Hans-Peter Nilsson wrote:
> > On Mon, 25 Mar 2013, Hans-Peter Nilsson wrote:
> > > That is, it's the only sim where the default config is "no": "no
> > > hardware enabled by default". If that number *decreases* due to
> > > a patch supposed to *enable* things, the patch seems wrong.
> > Oops: it's the number of *untested* cases that decrease when
> > enabling default-disabled hardware (yes, I do test and account
> > for that in the test-suite)... *blush*
> >
> > So ignore my previous post while I remove my foot from my mouth.
> It is really complicated and a lot of details. No apology needed. :)
>
> Does Mike's patch look ok based upon my testing?
Dunno, there was a bit of churn there and it wasn't clear what
the intent was, but as Mike has the required rights no review is
required AFAIK.
brgds, H-P