This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Pedro Alves'" <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Tue, 26 Mar 2013 22:58:16 +0100
- Subject: RE: [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.
- References: <20130326184101 dot 29735 dot 59747 dot stgit at brno dot lan>
Sorry about this mistake,
(I added this set/show command when I
fixed some problems with the coff pe reader).
I didn't really know the difference between the two...
Concerning the name of the variable,
you are right that using hyphens instead of
underscores seems to be the "unwritten?" rule.
I have no objection to switching to coff-pe-read.
Pierre Muller
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyà : mardi 26 mars 2013 19:41
> Ã : gdb-patches@sourceware.org
> Objet : [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger
> instead of uinteger.
>
> Being a uinteger means you can't disable debug output after enabling it...
>
> (gdb) show debug coff_pe_read
> Coff PE read debugging is 0.
> (gdb) set debug coff_pe_read 0
> (gdb) show debug coff_pe_read
> Coff PE read debugging is unlimited.
> (gdb)
>
> gdb/
> 2013-03-26 Pedro Alves <palves@redhat.com>
>
> * coff-pe-read.c (_initialize_coff_pe_read): Make the command
> zuinteger instead of uinteger.
> ---
> gdb/coff-pe-read.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c
> index c930bac..01e9b51 100644
> --- a/gdb/coff-pe-read.c
> +++ b/gdb/coff-pe-read.c
> @@ -707,12 +707,12 @@ void _initialize_coff_pe_read (void);
> void
> _initialize_coff_pe_read (void)
> {
> - add_setshow_uinteger_cmd ("coff_pe_read", class_maintenance,
> - &debug_coff_pe_read,
> - _("Set coff PE read debugging."),
> - _("Show coff PE read debugging."),
> - _("When set, debugging messages for coff reading "
> - "of exported symbols are displayed."),
> - NULL, show_debug_coff_pe_read,
> - &setdebuglist, &showdebuglist);
> + add_setshow_zuinteger_cmd ("coff_pe_read", class_maintenance,
> + &debug_coff_pe_read,
> + _("Set coff PE read debugging."),
> + _("Show coff PE read debugging."),
> + _("When set, debugging messages for coff reading "
> + "of exported symbols are displayed."),
> + NULL, show_debug_coff_pe_read,
> + &setdebuglist, &showdebuglist);
> }