This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Date: Wed, 27 Mar 2013 10:13:27 +0100
- Subject: RE: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling
- References: <20130319151436 dot GB20727 at calimero dot vinschen dot de> <20130319212554 dot GE4506 at adacore dot com> <000101ce2a6b$8c855a60$a5900f20$ at muller@ics-cnrs.unistra.fr> <20130326234318 dot GA4758 at adacore dot com> <20130327084722 dot GA22857 at calimero dot vinschen dot de>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Corinna Vinschen
> Envoyà : mercredi 27 mars 2013 09:47
> Ã : gdb-patches@sourceware.org
> Objet : Re: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c:
> Fix offset problem in signal string handling
>
> On Mar 26 16:43, Joel Brobecker wrote:
> > > cc1: warnings being treated as errors
> > > ../../src/gdb/windows-nat.c: In function 'handle_output_debug_string':
> > > ../../src/gdb/windows-nat.c:993:18: error: cast to pointer from integer
> of
> > > different size
> > > Makefile:972: recipe for target `windows-nat.o' failed
> > > make: *** [windows-nat.o] Error 1
> > > make: Leaving directory `/usr/local/src/gdbcvs/build-norm/gdb'
> > >
> > > This failure can be fixed by this simple patch, which should
> > > not affect the unreleased 64-bit Cygwin, a confirmation
> > > by Corinna would be nice on this part...
> > >
> > >
> > > ChangeLog entry:
> > >
> > > 2013-03-26 Pierre Muller <muller@sourceware.org>
> > >
> > > * windows-nat.c (handle_output_debug_string): Avoid typecast
> > > from integer of different size warning.
> >
> > This looks about right to me. Let's wait for Corinna to confirm
> > that it's OK with her too and commit.
>
> Yes, that looks good to me. Thanks for fixing this for 32 bit.
> Please apply.
Thank you, patch applied to main.
Pierre Muller