This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] cleanup: Wunused coff-pe-read

On 13-03-28 08:29 PM, Joel Brobecker wrote:

Aleksandar Ristovski  <aristovski@qnx.com>

         * coff-pe-read.c (add_pe_exported_sym): Remove unused DLL_NAME_LEN.
         (add_pe_forwarded_sym): Remove unused SECTION, DLL_NAME_LEN.
         (read_pe_exported_syms): Remove unused EXPORTIX.
         (pe_text_section_offset): Remove unused OPTHDR_OFS, NUM_ENTRIES,
         EXPORT_RVA, EXPORT_SIZE, EXPPTR, EXP_FUNCBASE, EXPDATA,
         ERVA, NAME_RVAS, ORDINALS, NEXP, ORDBASE, DLL_NAME.


Approved. One nit: all-cap ENTITY_NAME means "the value of entity_name".
You are removing the entities themselves, so their name should not
be capitalized.  I missed that in the two other patches I just approved.
Committed with corrected capitalization of removed entities. http://sourceware.org/ml/gdb-cvs/2013-04/msg00004.html 


Thank you,

Aleksandar Ristovski
QNX Software Systems
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]