On 03/21/2013 01:55 PM, Michael Eager wrote:
On 03/21/2013 12:49 PM, Eli Zaretskii wrote:
Date: Thu, 21 Mar 2013 12:04:34 -0700
From: Michael Eager <eager@eagerm.com>
Updated patch which fixes garbled output.
Thanks. This needs a suitable patch for the manual, to document this
new command, and also for NEWS.
Will do.
+ add_setshow_boolean_cmd ("display-linkname", class_support, &disp_linkname, _("\
+Set whether to display linkage name for functions."), _("\
+Show whether to display linkage name for functions."), NULL,
+ NULL,
+ show_disp_linkname,
+ &setlist, &showlist);
If this setting controls display of linkage name, why is the command
called "display-linkname" and not "display-linkage-name"?
Just saving keystrokes. I can change this.
Also, I think we need to explain what is a "linkage name" in the doc
string, because otherwise this doc string is 100% unhelpful, as it
says nothing at all about its purpose.
I'll update the patch with a more descriptive description.
Updated patch attached.
Changelog
gdb:
* 2013-03-27 Michael Eager <eager@eagercon.com>
* NEWS (set|show display-linkage-name): Announcement.
* ada-lang.c (is_known_support_routine): Add linkname, modify
find_frame_funname() call.
(ada_unhandled_exception_name_addr_from_raise): Likewise.
* defs.h (build_address_symbolic): Add linkname arg.
* disasm.c (dump_insns): Add linkname, modify build_address_symbolic() call.
* printcmd.c (MAX_LINKNAME_LEN): Define.
(print_address_symbolic): Add linkname, modify build_address_symbolic() call.
(print_address_symbolic): Print linkname if requested.
(build_address_symbolic): Add linkname argument, return linkage name
if different from symbol name.
* python/py-frame.c (frapy_is_valid): Add linkname, modify find_frame_funname()
call.
* stack.c (MAX_LINKNAME_LEN): Define.
(find_frame_funname): Add linkname argument, return linkage name if
different from symbol name.
(print_frame): Add linkname, modify find_frame_funname() call, print
linkname if requested.
* stack.h(find_frame_funname): Add linkname.
* top.c (disp_linkname): Define.
(show_disp_linkname): Display show linkage name status.
(init_main): Add "set/show display-linkname" command.
* top.h (disp_linkname): Declare.
doc:
* gdb.texinfo (set|show display-linkage-name): Document.