This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
auto-generated parts in posted patches (Re: [patch 2/2+rfc+doc] Install gcore by default (+new man page))
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 11 Apr 2013 11:36:46 +0100
- Subject: auto-generated parts in posted patches (Re: [patch 2/2+rfc+doc] Install gcore by default (+new man page))
- References: <20130407185443 dot GB15389 at host2 dot jankratochvil dot net> <83r4ilawlx dot fsf at gnu dot org> <20130408172841 dot GA28868 at host2 dot jankratochvil dot net> <87hajgua2o dot fsf at fleche dot redhat dot com> <516424FE dot 4050307 at redhat dot com> <20130409165525 dot GA29570 at host2 dot jankratochvil dot net> <51654DF0 dot 3090101 at redhat dot com> <20130410194910 dot GA3941 at host2 dot jankratochvil dot net> <20130411040309 dot GA20577 at host2 dot jankratochvil dot net>
On 04/11/2013 05:03 AM, Jan Kratochvil wrote:
> Forgot to state here were always replies one should strip all auto-generated
> parts from posted patches - so I do it. But I find that inconvenient. It is
> easier to skip a part of patch when reviewing it than to regenerate it
> hopefully the same way as the patch submitter because the source tree requires
> special autotools (old version + unpatched).
I fully agree. It's also very useful to see the generated bits to check
whether a submitter who has commit/write access is using the right versions
of the tools to regenerate the patches, and check whether the correct set
of files is being regenerated.
--
Pedro Alves