Re: [PATCH] store trace default-collect to target [5/6] doc

[Hui Zhu <teawater at gmail dot com>]

Hi Eli,

Thanks for your review.

On Fri, Apr 12, 2013 at 1:52 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Thu, 11 Apr 2013 14:19:03 +0800
>> From: Hui Zhu <hui_zhu@mentor.com>
>>
>> This patch is doc update for "QTDDCsrc" and "qTDC".
>
> Thanks.
>
>> +@item QTDDCsrc:@var{bytes}
>> +@cindex define default collect, remote request
>> +@cindex @samp{QTDDCsrc} packet
>> +@var{bytes} is the string, encoded in hexadecimal.
>> +It specify a source string of default collect.
>       ^^^^^^^
> "specifies"
>
> By the way, why is it called a "source" string?

Because it is same with QTDPsrc:  string, encoded in hexadecimal.  I
think it is not very good for this part now.  So I removed it.

>
>> +These packets request default collect on the target.  Replies to
>> +this packet generally take the form of the @code{QTDDCsrc} packet that
>> +define default collect.
>    ^^^^^^
> "defines"

Fixed.

>
>> +Replies:
>> +@table @samp
>> +@item DC@var{bytes}
>> +@var{bytes} is the string, encoded in hexadecimal.  It take the form of
>> +the @code{QTDDCsrc} packet that define default collect.^^^^
>                                    ^^^^^^
> "takes" and "defines"

Fixed.

>
> OK with those changes.


Post a new version.  Please help me review.

Best,
Hui

2013-04-16  Hui Zhu  <hui@codesourcery.com>

* gdb.texinfo (Tracepoint Packets) Add "QTDDCsrc" and "qTDC".

Attachment: defc-doc.txt
Description: Text document