This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Let dprintf can be saved

From: Hui Zhu <teawater at gmail dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: gdb-patches ml <gdb-patches at sourceware dot org>
Date: Sat, 20 Apr 2013 15:04:16 +0800
Subject: Re: [PATCH] Let dprintf can be saved
References: <CANFwon0p7x4X1qx=kqu-XRJ0XYfv8NDW4WxqST=w16VDUZTSzw at mail dot gmail dot com> <87fvymwkbi dot fsf at fleche dot redhat dot com>

On Sat, Apr 20, 2013 at 12:34 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> +static void
> Hui> +dprintf_print_recreate (struct breakpoint *tp, struct ui_file *fp)
>
> This needs a short introductory comment.
> See the other print_recreate methods for examples.

Fixed.

>
> I think this patch could use a test case.
> It could be added wherever the existing "save" tests live.

OK.  I will post a patch for it later.

Thanks,
Hui

>
> Tom

2013-04-18  Hui Zhu  <hui@codesourcery.com>

	PR gdb/15165

	* breakpoint.c (dprintf_print_recreate): New.
	(save_breakpoints): Let it not save dprintf commands.
	(initialize_breakpoint_ops): Set dprintf_print_recreate.

Attachment: dprintf-save.txt
Description: Text document

Follow-Ups:
- Re: [PATCH] Let dprintf can be saved
  - From: Hui Zhu
- Re: [PATCH] Let dprintf can be saved
  - From: Tom Tromey

References:
- [PATCH] Let dprintf can be saved
  - From: Hui Zhu
- Re: [PATCH] Let dprintf can be saved
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]