This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] PR 15075 dprintf interferes with "next"

On 04/23/2013 08:44 AM, Hui Zhu wrote:

--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
+/* Implement the "after_cond"  breakpoint_ops method for dprintf.  */
+
+static void
+dprintf_after_cond (struct bpstats *bs)
+{
+  bpstat tmp;
+
+  bs->stop = 0;
+  bs->print = 0;
+  bs->commands = b->commands;
+  tmp = bs->next;
+  bs->next = tmp;
+  incref_counted_command_line (bs->commands);
+  bpstat_do_actions_1 (&bs);
+  bs->next = tmp;
+}
This function must be incomplete. What is 'tmp' for? It is superfluous as written. 'b' is undefined, too. 

Keith
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]