Re: [RFC] PR 15075 dprintf interferes with "next"

[Hui Zhu <teawater at gmail dot com>]

On Wed, Apr 24, 2013 at 10:44 AM, Yao Qi <yao@codesourcery.com> wrote:
> On 04/24/2013 07:59 AM, Hui Zhu wrote:
>>
>> 2013-04-23  Yao Qi<yao@codesourcery.com>
>>             Hui Zhu<hui@codesourcery.com>
>>
>>         PR gdb/15075
>
>         ^^^^^^^^^^^^ "PR breakpoints/15075"
>
>
>>
>>         * breakpoint.c (bpstat_stop_status): Call b->ops->after_cond.
>>         (update_dprintf_command_list): Don't append "continue" command
>>         to the command of dprintf breakpoint.
>>         (base_breakpoint_after_cond): New.
>>         (base_breakpoint_ops): Add base_breakpoint_after_cond.
>>         (dprintf_after_cond): New.
>>         (initialize_breakpoint_ops): Set dprintf_after_cond.
>>         * breakpoint.h (breakpoint_ops): Add after_cond.
>>
>> 2013-04-23  Hui Zhu<hui@codesourcery.com>
>>
>>         PR gdb/15075
>>
>>         * gdb.base/dprintf.exp: Remove "continue" from "info breakpoint"
>>         test.
>
> We also need to stop checking "continue" in gdb.mi/mi-breakpoint-changed.exp
> also, as what patch [1] does.  B.T.W, why don't you add
> gdb.base/pr15075.[c,exp] from patch [1]?
>
> --
> Yao (éå)
>
> [1] http://sourceware.org/ml/gdb-patches/2013-02/msg00736.html

Oops, I am sorry that the discussion threads confused me.  Post a new
version for it.

And I didn't include the "disallows setting commands for dprintf"
patch because looks it is still in discussion.

Thanks,
Hui

2013-04-23  Yao Qi  <yao@codesourcery.com>
	    Hui Zhu  <hui@codesourcery.com>

	PR breakpoints/15075

	* breakpoint.c (bpstat_stop_status): Call b->ops->after_cond.
	(update_dprintf_command_list): Don't append "continue" command
	to the command of dprintf breakpoint.
	(base_breakpoint_after_cond): New.
	(base_breakpoint_ops): Add base_breakpoint_after_cond.
	(dprintf_after_cond): New.
	(initialize_breakpoint_ops): Set dprintf_after_cond.
	* breakpoint.h (breakpoint_ops): Add after_cond.

2013-04-23  Yao Qi  <yao@codesourcery.com>

	PR breakpoints/15075

	* gdb.base/dprintf.exp: DOn't check "continue" in the output
	of "info breakpoints".
	* gdb.mi/mi-breakpoint-changed.exp (test_insert_delete_modify):
	Don't check "continue" in script field.
	* gdb.base/pr15075.c: New.
	* gdb.base/pr15075.exp: New.

Attachment: dprintf-continue.txt
Description: Text document

Attachment: dprintf-continue-test.txt
Description: Text document